Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10581 request access email fix #10653

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it: Addresses email formatting issues when the guestbook is used at the time of a file access request

Which issue(s) this PR closes:

Closes #10581 Emails sent to Dataset Owners from "Guestbook at Request Access" missing key information and are hard to read due to Q/As being in random order and no formatting between

Special notes for your reviewer:

Suggestions on how to test this: Notes in the issue are comprehensive.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@sekmiller sekmiller added this to the 6.3 milestone Jun 25, 2024
@sekmiller sekmiller added the Size: 3 A percentage of a sprint. 2.1 hours. label Jun 25, 2024

This comment has been minimized.

1 similar comment
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10581-request-access-email-fix
ghcr.io/gdcc/configbaker:10581-request-access-email-fix

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good w.r.t. code. I haven't tried it but I did scan the issue and see that this addresses all the parts.

Any release note? Or guide changes - no since we don't describe the email format?

@sekmiller
Copy link
Contributor Author

I wasn't sure if it was worthy of a release note - more of a catch-all bug fix.

@qqmyers
Copy link
Member

qqmyers commented Jun 25, 2024

I'd play it up as "Multiple improvements to Guestbook response emails making it easier to organize and process them." - mostly because it was a community request that might be of interest elsewhere.

@stevenwinship stevenwinship self-assigned this Jun 25, 2024
@stevenwinship
Copy link
Contributor

image
image

@stevenwinship stevenwinship merged commit 9fc757f into develop Jun 25, 2024
19 checks passed
@stevenwinship stevenwinship removed their assignment Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
3 participants